search

pineapplegiant / spaceduck

🚀 🦆 An intergalactic space theme for Vim, Terminal, and more!
https://pineapplegiant.github.io/spaceduck/
MIT License
804 stars 30 forks source link

I made a duckduckgo port, but I am unsure where to put it #31

Closed spcbfr closed 3 years ago

spcbfr commented 3 years ago

Hey, thanks for the great theme ! I made this spaceduck theme for duckduckgo (how ironic lol) but I am not sure if I should put it in the official repo (it may become too crowded) or in spaceduck-terminal (this one is for terminal ports only)

Here is how it looks : image

to get it you need to navigate to the settings > click load settings on the right side > type spaceduck-ddg > save and exit. image

pineapplegiant commented 3 years ago

Sorry for getting to you late @YoussefBouzekri! Would you like to be the owner of this code? You can create a repo, and I'll add a link to the readme. The only other option would be me to host the code and link here and have you as a contributor. This repo's for the vim/neovim plugin so obviously putting it here wouldn't be good. Let me know what you think?

I've also thought of creating an organization too since I've been getting a lot of ports...idk

spcbfr commented 3 years ago

@pineapplegiant I would love to manage the repo (will be a great learning experience for me since I have never worked on a serious open-source project before), you could then link to that repo in this repo's README and move all of the ports to the new "Spaceduck Ports" repo so that it doesn't get too confusing

spcbfr commented 3 years ago

idk if you know about it but there is also a firefox theme, I didn't know spaceduck was everywhere lol 🤣

pineapplegiant commented 3 years ago

That sound like a great idea! Yeah luckily I got an email from the firefox theme creator telling me about it, so I wasn't too surprised. I've been meaning to add that link here. Yeah we'd love to have you as a contributor!

Definitely will bug you when the two other variant color scheme variants come out both light and middle contrast themes, so you can add that in. I might ask you to change the scheme a bit too, I feel like cyan is a good default link color, but that's personal preference of course!

spcbfr commented 3 years ago

image I feel like this is too much blue/purple idk.. I'll keep it if you prefer this

I must say this in advance , I might not be able to do much work on the repo these next few weeks until the summer vacation (mid june where I live) because of final exams, I will try to do my best tho 🦆

pineapplegiant commented 3 years ago

Hmm yeah. Maybe Blue on the title and gray as the url or something. Just matching googles vibe basically idk.

And that’s no worries don’t fail because of spaceduck! Spaceduck devs are A students. If you want you can give me collaborator access on a dev branch like how I have for @jinh0 hehe

spcbfr commented 3 years ago

Alright I'll start working on it !

pineapplegiant commented 3 years ago

Hey @YoussefBouzekri I think I might have miscommunicated with you and I apologize 😢 . I saw you created a whole repo for spaceduck-ports. I wanted to say thank you, but I was thinking you should just self-host the duckduckgo theme and I'll link to it from here. It might be a little overkill to have a repo for just ports.

As far as where to put the link, I thought about it, and it makes sense to follow how Neovim has and start a wiki, especially since the readme is getting a little long!

https://github.com/neovim/neovim/wiki/Related-projects

(When you had said spaceduck-ports repo, I thought you meant that I should start it, so that's my apology for misunderstanding, I didn't want to imply you should host it).