feat: Qdrant as a supported knowledge base

pinecone-io / canopy

Retrieval Augmented Generation (RAG) framework and context engine powered by Pinecone

https://www.pinecone.io/

Apache License 2.0

976 stars 121 forks source link

feat: Qdrant as a supported knowledge base #244

Closed Anush008 closed 8 months ago

Anush008 commented 10 months ago

Description

This PR adds support for Qdrant to be used as a knowledge base.

Type of Change

[x] New feature (non-breaking change which adds functionality)
[x] This change requires a documentation update

Test Plan

Tests have been added to tests/system/qdrant for the sync and async implementations and are configured to run using both, an in-memory Qdrant instance and Qdrant server(if running at port 6333, skipped otherwise).

Note

The qdrant_client dependency can be gated behind an extra if needed and CLI support can be added subsequently.

igiloh-pinecone commented 10 months ago

Thank you @Anush008 for the great contribution!!
We are still in the process of reviewing this PR, will publish the review in the coming days.

Anush008 commented 10 months ago

Thanks @igiloh-pinecone.

ChristopherDosin commented 9 months ago

We are still in the process of reviewing this PR, will publish the review in the coming days.

Any news on that a month later? :)

igiloh-pinecone commented 9 months ago

We are still in the process of reviewing this PR, will publish the review in the coming days.

Any news on that a month later? :)

Hi @ChristopherDosin,
As I mentioned before, we are considering an internal refactor of the KnowledgeBase class, that could affect the approach taken in this PR. But since this is still in internal discussions and design process, we shouldn't delay merging this PR any longer.
I'll publish a review of the current standing PR in the coming day or two.
Thank you for you patience! 🙏

ChristopherDosin commented 9 months ago

We are still in the process of reviewing this PR, will publish the review in the coming days.

Any news on that a month later? :)

Hi @ChristopherDosin, As I mentioned before, we are considering an internal refactor of the KnowledgeBase class, that could affect the approach taken in this PR. But since this is still in internal discussions and design process, we shouldn't delay merging this PR any longer. I'll publish a review of the current standing PR in the coming day or two. Thank you for you patience! 🙏

Awesome, thank you my friend - Just wondering which one performs better :)

brightsparc commented 8 months ago

Looking forward to having this land. Anything holding this up?

igiloh-pinecone commented 8 months ago

Looking forward to having this land. Anything holding this up?

As far as I recall some system test failed in the merge queue 🤔 .
Trying to re-merge this now, let's see.

Anush008 commented 8 months ago

@igiloh-pinecone, I've updated the branch. Could you try now please?

Anush008 commented 8 months ago

The flaky CI failures seem to arise from unrelated files.

UPDATE: This should be resolved with #327.

brightsparc commented 8 months ago

Nice. When is the next release likely to get cut?

izellevy commented 8 months ago

We have a new release: https://github.com/pinecone-io/canopy/releases/tag/v0.9.0