update merging namespaces notebook - Githubissues

pinecone-io / examples

Jupyter Notebooks to help you get hands-on with Pinecone vector databases

MIT License

2.66k stars 988 forks source link

update merging namespaces notebook #365

Closed junefish closed 2 months ago

junefish commented 2 months ago

Problem

metadata not included in upsert
code would fail if namespace contained more than 10k vectors

Solution

included metadata in upsert
added error handling for namespaces>10k

Type of Change

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update
[ ] Infrastructure change (CI configs, etc)
[ ] Non-code change (docs, etc)
[X] None of the above: update to notebook

Test Plan

tested in colab

namespaces larger than 10k
vectors with metadata

review-notebook-app[bot] commented 2 months ago

Check out this pull request on

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

junefish commented 2 months ago

@cwaddingham