Closed jhamon closed 8 months ago
@jhamon, awesome work. Excited to get that out!
As for your open question: we do not plan to add anything else in the near future, but it theoretically might happen at some point. However if we end up adding just some auxiliary data it might be possible to modify the iterator function to deal with it/strip it away.
@gdj0nes WDYT?
I removed the full_page check and added in docstrings.
Problem
Need to implement the new data plane list endpoint.
Solution
pinecone/core
are generated from spec files and can be ignored for this review.pinecone/data/index.py
main implementationpinecone/grpc/index_grpc.py
main implementationtests/integration/data/conftest.py
adjustments to test setup, mainly to generate a new namespace to hold vectors for list testing data.tests/integration/data/seed.py
to upsert a larger number of vectors, so I would have enough data to page throughtests/integration/data/test_list.py
tests/integration/data/test_list_errors.py
Open questions
{'id': '1'}
in the vectors array? For convenience thelist()
method is currently implemented as a generator function that abstracts the pagination steps and yields a flat list of id values. For a use case where you were going to immediately fetch those ids, this seems ideal. But would be limiting if we ever wanted to return more than just ids here.Usage
Install the dev client version
install "pinecone-client[grpc]"==3.1.0.dev1
REST
GRPC
Type of Change
Testing
Try out the dev version.