pinecone-io / pinecone-python-client

The Pinecone Python client
https://www.pinecone.io/docs
Apache License 2.0
284 stars 78 forks source link

do not override port if defined in host #362

Closed haruska closed 2 months ago

haruska commented 2 months ago

Problem

For an Index gRPC connection, port 443 is blindly added to the configured host for setting up the endpoint. A user should be able to specify a port for connection.

Solution

This PR will no longer append ":443" to the configured gRPC endpoint if a colon is already present in the host configuration.

Type of Change

Test Plan

Unit tests were updated for omitting and including a port in the host config. Verified that the client could connect to an Index on a port other than 443.