For the basic functionality, needed to update the create index and configure index actions
The UX around the generated enum class, DeletionProtection, seemed extremely poor so I added a custom wrapper class IndexModel and incorporated it into the describe_index and list_indexes actions
Update and add new tests
Remove export of the generated IndexModel from the top-level __init__.py file.
This ended up being a much bigger lift than expected, but as a nice side effect we're no longer exposing generated objects in responses from these various actions. That creates some additional flexibility for future refactoring work.
Type of Change
[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[x] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update
[ ] Infrastructure change (CI configs, etc)
[ ] Non-code change (docs, etc)
Test Plan
Describe specific steps for validating this change.
Problem
Implement deletion protection for python sdk
Solution
DeletionProtection
, seemed extremely poor so I added a custom wrapper classIndexModel
and incorporated it into thedescribe_index
andlist_indexes
actions__init__.py
file.This ended up being a much bigger lift than expected, but as a nice side effect we're no longer exposing generated objects in responses from these various actions. That creates some additional flexibility for future refactoring work.
Type of Change
Test Plan
Describe specific steps for validating this change.