search

pinecone-io / pinecone-python-client

The Pinecone Python client
https://www.pinecone.io/docs
Apache License 2.0
309 stars 81 forks source link

[Feat] asyncio for grpc data interactions #398

Open jhamon opened 1 month ago

jhamon commented 1 month ago

Problem

Describe the purpose of this change. What problem is being solved and why?

Solution

Describe the approach you took. Link to any relevant bugs, issues, docs, or other resources.

Type of Change

Test Plan

Describe specific steps for validating this change.

gitguardian[bot] commented 1 month ago

⚠️ GitGuardian has uncovered 6 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request
| GitGuardian id | GitGuardian status | Secret | Commit | Filename | | | -------------- | ------------------ | ------------------------------ | ---------------- | --------------- | -------------------- | | [14203991](https://dashboard.gitguardian.com/workspace/465975/incidents/14203991?occurrence=170654948) | Triggered | Generic High Entropy Secret | e665c0da7777bb2055cb36bd53c16e513201fc9a | app2.py | [View secret](https://github.com/pinecone-io/pinecone-python-client/commit/e665c0da7777bb2055cb36bd53c16e513201fc9a#diff-f9ccae8bf0fa36e7ca3666ec1ba2e02ebf0ef6ec4090b3ede0e6a7e99e2a9ef3R5) | | [14203991](https://dashboard.gitguardian.com/workspace/465975/incidents/14203991?occurrence=170654950) | Triggered | Generic High Entropy Secret | e665c0da7777bb2055cb36bd53c16e513201fc9a | app3.py | [View secret](https://github.com/pinecone-io/pinecone-python-client/commit/e665c0da7777bb2055cb36bd53c16e513201fc9a#diff-04470b509b610a299205e49649711c1d7201e25c968e82dcfdd5fa17a7b258d0R40) | | [14203991](https://dashboard.gitguardian.com/workspace/465975/incidents/14203991?occurrence=170654952) | Triggered | Generic High Entropy Secret | e665c0da7777bb2055cb36bd53c16e513201fc9a | app2.py | [View secret](https://github.com/pinecone-io/pinecone-python-client/commit/e665c0da7777bb2055cb36bd53c16e513201fc9a#diff-f9ccae8bf0fa36e7ca3666ec1ba2e02ebf0ef6ec4090b3ede0e6a7e99e2a9ef3R4) | | [14203991](https://dashboard.gitguardian.com/workspace/465975/incidents/14203991?occurrence=170654949) | Triggered | Generic High Entropy Secret | 1c9632e4e3e8a00ad8b6f5fef622a84172aec073 | app2.py | [View secret](https://github.com/pinecone-io/pinecone-python-client/commit/1c9632e4e3e8a00ad8b6f5fef622a84172aec073#diff-f9ccae8bf0fa36e7ca3666ec1ba2e02ebf0ef6ec4090b3ede0e6a7e99e2a9ef3L4) | | [14203991](https://dashboard.gitguardian.com/workspace/465975/incidents/14203991?occurrence=170654951) | Triggered | Generic High Entropy Secret | 1c9632e4e3e8a00ad8b6f5fef622a84172aec073 | app2.py | [View secret](https://github.com/pinecone-io/pinecone-python-client/commit/1c9632e4e3e8a00ad8b6f5fef622a84172aec073#diff-f9ccae8bf0fa36e7ca3666ec1ba2e02ebf0ef6ec4090b3ede0e6a7e99e2a9ef3L5) | | [14203991](https://dashboard.gitguardian.com/workspace/465975/incidents/14203991?occurrence=170654953) | Triggered | Generic High Entropy Secret | 1c9632e4e3e8a00ad8b6f5fef622a84172aec073 | app3.py | [View secret](https://github.com/pinecone-io/pinecone-python-client/commit/1c9632e4e3e8a00ad8b6f5fef622a84172aec073#diff-04470b509b610a299205e49649711c1d7201e25c968e82dcfdd5fa17a7b258d0L40) |
🛠 Guidelines to remediate hardcoded secrets
1. Understand the implications of revoking this secret by investigating where it is used in your code. 2. Replace and store your secrets safely. [Learn here](https://blog.gitguardian.com/secrets-api-management?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment) the best practices. 3. Revoke and [rotate these secrets](https://docs.gitguardian.com/secrets-detection/secrets-detection-engine/detectors/generics/generic_high_entropy_secret#revoke-the-secret?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment). 4. If possible, [rewrite git history](https://blog.gitguardian.com/rewriting-git-history-cheatsheet?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment). Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data. To avoid such incidents in the future consider - following these [best practices](https://blog.gitguardian.com/secrets-api-management/?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment) for managing and storing secrets including API keys and other credentials - install [secret detection on pre-commit](https://docs.gitguardian.com/ggshield-docs/integrations/git-hooks/pre-commit?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment) to catch secret before it leaves your machine and ease remediation.

🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.