pinecone-io / pinecone-ts-client

The official TypeScript/Node client for the Pinecone vector database
https://www.pinecone.io
Apache License 2.0
166 stars 36 forks source link

Update CI to test newer versions of Node and test fewer versions of Bun #228

Closed aulorbe closed 1 month ago

aulorbe commented 1 month ago

Problem

We currently only test Node version 16.x, but there are much newer versions with upgraded capabilities. To ensure full coverage, we want to add in 18.x and 20.x. This PR does that.

Note: this will increase the time it takes for our CI pipeline to complete, but we have discussed, and the increased latency is worth it to cover more modern versions of Node.

We have also decreased the number of bun versions tested since they have released a major new version 1.1.x. We originally had many versions out of an abundance of caution leading up to releasing Pinecone serverless. Now that there have been major releases of bun cut more recently, it's my opinion that we only really need to test the following:

Our CI pipeline still takes a while, but ultimately I think this is better test coverage, and we can do a quick follow-up PR with some hacks to decrease the overall time at some point in the near future.

Type of Change