Fix local install - Githubissues

pinecone-io / sample-apps

15 stars 7 forks source link

Fix local install #5

Closed zackproser closed 2 months ago

zackproser commented 2 months ago

Problem

When installed locally through the npx command, there are currently two errors blocking forward progress:

The npm install command fails due to outdated link syntax
The bootstrap API call CAN fail if you're not running on exactly port 3000

Solution

Update package.json link syntax
Dynamically read the port the app is running on from the environment

Type of Change

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update
[ ] Infrastructure change (CI configs, etc)
[ ] Non-code change (docs, etc)
[ ] None of the above: (explain here)

Test Plan

Describe specific steps for validating this change.

zackproser commented 2 months ago

Thanks for reviewing!