search

pinecone-router / router

The extensible client-side router for Alpine.js v3
https://pinecone-example.vercel.app/
MIT License
239 stars 7 forks source link

Documentation for event listener #25

Closed thbley closed 10 months ago

thbley commented 10 months ago

Describe the bug document.body.addEventListener() should be document.addEventListener() in README.md ?

To Reproduce

README.md has: document.body.addEventListener('pinecone-start', () => NProgress.start()); document.body.addEventListener('pinecone-end', () => NProgress.done());

index.ts has: const startLoading = () => { document.dispatchEvent(PineconeRouter.loadStart) ... const endLoading = () => { document.dispatchEvent(PineconeRouter.loadEnd)

rehhouari commented 10 months ago

Wow issues close automatically when you reference it in a pull request! Thanks for submitting this I missed it when I was updating!