pinellolab / CRISPResso2

Analysis of deep sequencing data for rapid and intuitive interpretation of genome editing experiments
Other
256 stars 91 forks source link

Fix the assignment of multiple quantification window coordinates #403

Closed Colelyman closed 3 months ago

Colelyman commented 3 months ago

This change is slightly cleaner because it addresses the root issue that some columns are strings (and can therefore not be converted to numeric types). Now if an error does occur when converting the dfs to numeric types it won't be swallowed up.


The rationale behind this is that the behavior around the cloned amplicon is quite different than if the qwc are specified directly for the amplicon.

This function just computes the relative indexes without doing an alignment.

This change is slightly cleaner because it addresses the root issue that some columns are strings (and can therefore not be converted to numeric types). Now if an error does occur when converting the dfs to numeric types it won't be swallowed up.



This is in an effort to be consistent with the behavior and results of CRISPRessoPooled.