pinellolab / CRISPResso2

Analysis of deep sequencing data for rapid and intuitive interpretation of genome editing experiments
Other
256 stars 91 forks source link

Fix Cython types and improve output consistency #444

Closed Colelyman closed 2 weeks ago

Colelyman commented 2 weeks ago

This PR addresses the recent change with the release of numpy==2.0.0, where it seems that np.int_t was deprecated.

This PR also updates how include_idxs and exclude_idxs are output, because now with numpy==2.0.0 the integers will be printed out with their types (e.g. np.int64(32) vs 32 in previous versions). No include_idxs and exclude_idxs are vanilla Python lists with vanilla Python ints, with the added benefit of more consistent output in CRISPResso_reference_info.txt (see: https://github.com/edilytics/CRISPResso2_tests/pull/37).

Should only be merged in after the corresponding test branch.