search

pinellolab / singlecellvr

13 stars 4 forks source link

app datasets list by requesting an api #10

Open qinqian opened 4 years ago

qinqian commented 4 years ago

The two app should be run with different ports. The reason why one port is not working is the failure of requests of the api.

davidfstein commented 4 years ago

Hi Qian, This all looks good. The only thing I need is a get_dataset_type endpoint. Right now, when I parse the datasets, there is a file that tells me if the dataset is paga, stream, scanpy, etc. I need this information to render the visualization correctly. The following API would be ideal.

def get_dataset_type(db_name):
    ## type is one of ['STREAM', 'PAGA', 'SCANPY', and anything else we support in the future]
    return jsonify({"type": type})
qinqian commented 3 years ago

Hi David,

Please see my latest commits, I use a simple way to implement the interface by local file name and extend to other two tools with demo in the function docstring. Happy to discuss with you later.

Best, Qian

davidfstein commented 3 years ago

@qinqian This looks great! I'll test it out and merge it

qinqian commented 3 years ago

Please use this pull request to merge the fix of Seurat 4.