Maybe there's some parameter somewhere to increase the memory limit for the testing process, but I also felt like optimising a few things that I could optimise anyways, and maybe GitHub Actions will stop complaining.
Optimisations include:
Avoid copying VRAM to Vec<u8>, which in turn is copied[^?] back to ppu.tilemap: VRamContents
[^?]: is copy elision a thing with VRamContents::load(&[u8]) -> VRamContents? Should we have a VRamContents::load(&self, &[u8]) instead? Maybe that's what's causing the stack overflow
diogotito
commented
3 months ago
Maybe there's some parameter somewhere to increase the memory limit for the testing process, but I also felt like optimising a few things that I could optimise anyways, and maybe GitHub Actions will stop complaining.
Optimisations include:
Vec<u8>, which in turn is copied[^?] back toppu.tilemap: VRamContents[^?]: is copy elision a thing with
VRamContents::load(&[u8]) -> VRamContents? Should we have aVRamContents::load(&self, &[u8])instead? Maybe that's what's causing the stack overflow