search

pinfang / pe

0 stars 0 forks source link

dg bug - explaination for parser section can be more detailed with words #17

Open pinfang opened 3 years ago

pinfang commented 3 years ago

sequence diagram is clear, but it would be better with words explaination, especially when your diagram is super small!

nus-pe-bot commented 3 years ago

Team's Response

Issue unclear, but it would be better with a diagram. Also, Do not post suggestions in PE.

Items for the Tester to Verify

:question: Issue response

Team chose [response.IssueUnclear]

Reason for disagreement: first issue is your diagram is too small for me to see

i cannot even differentiate a dotted line from solid line without enlarging the diagram, for your info, i have to enlarge to 800% to see it, and luckily your diagrams are clear and the resolution is high

2nd issue is explaination is too brief

you should provide more explaination of how parser works, not just simply shows a diagram, your diagram is just like a code snippet to me

e.g. from ab3

image.png