pinfang / pe

0 stars 0 forks source link

able to add dates that are not in the year 2021 #5

Open pinfang opened 3 years ago

pinfang commented 3 years ago

there isnt 29 feb in 2020, but i could still add, and the sytem change my date to 28 Feb 2021, it should show error message

image.png

nus-pe-bot commented 3 years ago

Team's Response

This issue exists with the LocalDateTime library, where a rare unacceptable date is converted to an acceptable date. Severity changed to low because it appears only in rare situations and causes a minor inconvenience only.

Items for the Tester to Verify

:question: Issue severity

Team chose [severity.Low] Originally [severity.High]

Reason for disagreement: I do not agree that the severity could be changed to low, maybe medium

how do you judge a situation that is rare if the forgetful user suddenly want to add a lot of deadlines or events to 29-02-2021? this might happen when you want to organise an event e.g. have a surprise party for someone's birthday that falls on 29 feb and you forgot that there is no 29 feb in 2021, this will cause a great inconveniece to the user if the date is saved to 28 feb 2021 instead

if you know that this is a constraint of the library, then you should fix it and show an error message that 29-02-2021 does not exist

in LocalDate library, you can use xxx.isLeapYear() to check