search

ping / instagram_private_api_extensions

An extension module to https://github.com/ping/instagram_private_api
MIT License
124 stars 26 forks source link

Modified requirements and installed packages #18

Closed Kaszanas closed 5 years ago

Kaszanas commented 5 years ago

What does this PR do?

This change aims to keep the package updated with the newer version of Moviepy. In this case the version that will be included is 1.0.0

Please note that there is Moviepy 1.0.1 available.

Why was this PR needed?

Upgrading the package will allow for less chance of clashing dependencies with other libraries posted on GitHub

What are the relevant issue numbers?

17

Does this PR meet the acceptance criteria?

ping commented 5 years ago

Why do you not choose to update to 1.0.1? There are breaking changes.

ERROR: test_prepare_video (test_media.TestMedia)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/travis/build/ping/instagram_private_api_extensions/tests/test_media.py", line 69, in test_prepare_video
    save_only=True)
  File "instagram_private_api_extensions/media.py", line 227, in prepare_video
    verbose=False, progress_bar=progress_bar, preset=preset, remove_temp=True)
TypeError: write_videofile() got an unexpected keyword argument 'progress_bar'

======================================================================
ERROR: test_prepare_video2 (test_media.TestMedia)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/travis/build/ping/instagram_private_api_extensions/tests/test_media.py", line 93, in test_prepare_video2
    self.TEST_VIDEO_PATH, max_size=(480, 480), min_size=(0, 0))
  File "instagram_private_api_extensions/media.py", line 227, in prepare_video
    verbose=False, progress_bar=progress_bar, preset=preset, remove_temp=True)
TypeError: write_videofile() got an unexpected keyword argument 'progress_bar'

======================================================================
ERROR: test_remote_video (test_media.TestMedia)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/travis/build/ping/instagram_private_api_extensions/tests/test_media.py", line 148, in test_remote_video
    video_url, aspect_ratios=1.0, max_duration=10.0)
  File "instagram_private_api_extensions/media.py", line 227, in prepare_video
    verbose=False, progress_bar=progress_bar, preset=preset, remove_temp=True)
TypeError: write_videofile() got an unexpected keyword argument 'progress_bar'

----------------------------------------------------------------------
Kaszanas commented 5 years ago

@ping I want it to match my current state of development on video processing project so I can upgrade it later to 1.0.1 all at once.

Let me get back into the files once again and try to fix this problem.

But I must say that the Moviepy library is quite a mess. I am working with it for over 4 months now.

https://github.com/Zulko/moviepy/issues/910

I believe this is the origin of this issue.

ping commented 5 years ago

47e3d8c0fa6abcc8b8269dbbbc36046280702033 Updated to moviepy 1.0.1 and fixed the breaking changes.