search

ping / odmpy

A simple command line manager for OverDrive/Libby loans. Download your library loans from the command line.
GNU General Public License v3.0
288 stars 19 forks source link

add --mergecodec option, add support for using libfdk_aac #45

Closed holyspiritomb closed 1 year ago

holyspiritomb commented 1 year ago

If merged, users who have compiled ffmpeg with libfdk_aac support will be able to specify --mergecodec="libfdk_aac" to use the Fraunhofer FDK AAC audio codec instead of the default AAC when --mergeformat is set to m4b, which results in significantly faster encoding.

mergecodec defaults to aac if not specified. In the event of setting mergecodec to a value without setting --mergeformat=m4b, this option is ignored.

Example of speed difference:

With the default aac encoder, the ffmpeg output on my machine indicates a speed of ~47x during the m4b creation. With --mergecodec="libfdk_aac", the speed for creation of the same audiobook m4b file is ~129x.

coveralls commented 1 year ago

Coverage Status

coverage: 88.771% (+0.005%) from 88.766% when pulling 3823b1d4043de2867875cd210832c81c0d40f432 on holyspiritomb:fdk_aac into 794ce8077e41da661f076fd0a9ddcc027b6d88f5 on ping:master.

ping commented 1 year ago

Thanks for the PR.