search

pingcap / community

TiDB community content
Apache License 2.0
263 stars 153 forks source link

Nominate winkyao as TOC member #746

Closed sunxiaoguang closed 1 year ago

sunxiaoguang commented 1 year ago

I (@sunxiaoguang) thereby nominate @winkyao as TOC member and call for a vote.

Closes #745

ti-chi-bot commented 1 year ago

[REVIEW NOTIFICATION]

This pull request has been approved by:

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment. After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review. Reviewer can cancel approval by submitting a request changes review.
sunxiaoguang commented 1 year ago

/hold

ti-chi-bot commented 1 year ago

@baiyuqing: Thanks for your review. The bot only counts approvals from reviewers and higher roles in list, but you're still welcome to leave your comments.

In response to [this](https://github.com/pingcap/community/pull/746#pullrequestreview-1343469977): > Instructions for interacting with me using PR comments are available [here](https://prow.tidb.net/command-help). If you have questions or suggestions related to my behavior, please file an issue against the [ti-community-infra/tichi](https://github.com/ti-community-infra/tichi/issues/new?title=Prow%20issue:) repository.
ti-chi-bot commented 1 year ago

@niubell: Thanks for your review. The bot only counts approvals from reviewers and higher roles in list, but you're still welcome to leave your comments.

In response to [this](https://github.com/pingcap/community/pull/746#pullrequestreview-1343482715): > Instructions for interacting with me using PR comments are available [here](https://prow.tidb.net/command-help). If you have questions or suggestions related to my behavior, please file an issue against the [ti-community-infra/tichi](https://github.com/ti-community-infra/tichi/issues/new?title=Prow%20issue:) repository.
sunxiaoguang commented 1 year ago

/unhold

sunxiaoguang commented 1 year ago

/merge

ti-chi-bot commented 1 year ago

@sunxiaoguang: /merge in this pull request requires 1 approval(s).

In response to [this](https://github.com/pingcap/community/pull/746#issuecomment-1479580012): >/merge Instructions for interacting with me using PR comments are available [here](https://prow.tidb.net/command-help). If you have questions or suggestions related to my behavior, please file an issue against the [ti-community-infra/tichi](https://github.com/ti-community-infra/tichi/issues/new?title=Prow%20issue:) repository.
winkyao commented 1 year ago

/merge

ti-chi-bot commented 1 year ago

@winkyao: /merge in this pull request requires 1 approval(s).

In response to [this](https://github.com/pingcap/community/pull/746#issuecomment-1479594678): >/merge Instructions for interacting with me using PR comments are available [here](https://prow.tidb.net/command-help). If you have questions or suggestions related to my behavior, please file an issue against the [ti-community-infra/tichi](https://github.com/ti-community-infra/tichi/issues/new?title=Prow%20issue:) repository.
winkyao commented 1 year ago

/approve

winkyao commented 1 year ago

/merge

ti-chi-bot commented 1 year ago

This pull request has been accepted and is ready to merge.

Commit hash: b2975780461097244d8f4589bd72c6d88a3e1f93