pingcap / community

TiDB community content
Apache License 2.0
263 stars 153 forks source link

team/tidb: a vote for elsa0520 as TiDB reviewer #762

Closed winoros closed 1 year ago

winoros commented 1 year ago

just as the title said

ti-chi-bot[bot] commented 1 year ago

[LGTM Timeline notifier]

Timeline:

winoros commented 1 year ago

/hold for 3 days

ti-chi-bot[bot] commented 1 year ago

@time-and-fate: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to [this](https://github.com/pingcap/community/pull/762#pullrequestreview-1465074112): > Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
ti-chi-bot[bot] commented 1 year ago

@AilinKid: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to [this](https://github.com/pingcap/community/pull/762#pullrequestreview-1466504263): > Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
ti-chi-bot[bot] commented 1 year ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: AilinKid, disksing, qw4990, time-and-fate Once this PR has been reviewed and has the lgtm label, please assign zhangyangyu for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - ~~[teams/tidb/OWNERS](https://github.com/pingcap/community/blob/master/teams/tidb/OWNERS)~~ [disksing,qw4990] - **[votes/OWNERS](https://github.com/pingcap/community/blob/master/votes/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
AilinKid commented 1 year ago

/merge

winoros commented 1 year ago

@zhangyangyu Please help merge it? Though i can merge it by myself.

ti-chi-bot commented 1 year ago

In response to a cherrypick label: cannot checkout do-not-merge/hold: error checking out do-not-merge/hold: exit status 1. output: error: pathspec 'do-not-merge/hold' did not match any file(s) known to git

ti-chi-bot commented 1 year ago

In response to a cherrypick label: cannot checkout size/S: error checking out size/S: exit status 1. output: error: pathspec 'size/S' did not match any file(s) known to git

ti-chi-bot commented 1 year ago

In response to a cherrypick label: cannot checkout lgtm: error checking out lgtm: exit status 1. output: error: pathspec 'lgtm' did not match any file(s) known to git