search

pingcap / community

TiDB community content
Apache License 2.0
260 stars 151 forks source link

A Vote for CabinfeverB as TiDB Reviewer #770

Closed qw4990 closed 10 months ago

qw4990 commented 10 months ago

A Vote for CabinfeverB as TiDB Reviewer

Proposal

@CabinfeverB has been working on the related repositories like 'tikv/pd' for more than one year. ​He fixed some bugs related to TSO in the pd client to optimize recovery time. In recent months, he has been working on the feature Resource Control in TiDB. He was involved in resource group bug fixes, dynamic calibrate resource, runaway query management, etc.

I (@qw4990) hereby nominate @CabinfeverB as TiDB Reviewer and call for a vote.

Deadline

The vote will be open for at least 3 days unless there is an objection or not enough votes.

Scope

Result

See also: https://github.com/pingcap/community/pull/769

bb7133 commented 10 months ago

I will make a '+1' vote for the nomination.

Please address my comment.

qw4990 commented 10 months ago

All updated @bb7133 PTAL

ti-chi-bot[bot] commented 10 months ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: disksing Once this PR has been reviewed and has the lgtm label, please assign zhangyangyu for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - ~~[teams/tidb/OWNERS](https://github.com/pingcap/community/blob/master/teams/tidb/OWNERS)~~ [disksing] - **[votes/OWNERS](https://github.com/pingcap/community/blob/master/votes/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
ti-chi-bot[bot] commented 10 months ago

[LGTM Timeline notifier]

Timeline: