pingcap / community

TiDB community content
Apache License 2.0
260 stars 151 forks source link

votes: a vote for jiyfhust as the reviewer #772

Closed zimulala closed 9 months ago

zimulala commented 9 months ago

As stated in the title.

joccau commented 9 months ago

Why are some members from membership.json(https://github.com/pingcap/community/blob/0ae4dd6f9d929e5e6657b9322433cdcc73de431f/teams/tidb/membership.json#L4) not in https://github.com/orgs/pingcap/teams/tidb-maintainers ?

zhangyangyu commented 9 months ago

Why are some members from membership.json(

https://github.com/pingcap/community/blob/0ae4dd6f9d929e5e6657b9322433cdcc73de431f/teams/tidb/membership.json#L4

) not in https://github.com/orgs/pingcap/teams/tidb-maintainers ?

Maybe removed previously but they do not accept the remediate invitation?

ti-chi-bot[bot] commented 9 months ago

[LGTM Timeline notifier]

Timeline:

ti-chi-bot[bot] commented 9 months ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: disksing, lance6716 Once this PR has been reviewed and has the lgtm label, please assign zhangyangyu for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - ~~[teams/tidb/OWNERS](https://github.com/pingcap/community/blob/master/teams/tidb/OWNERS)~~ [disksing,lance6716] - **[votes/OWNERS](https://github.com/pingcap/community/blob/master/votes/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment