promote xzhangxian1008 as TiDB reviewer

pingcap / community

TiDB community content

Apache License 2.0

260 stars 151 forks source link

promote xzhangxian1008 as TiDB reviewer #779

Closed XuHuaiyu closed 5 months ago

XuHuaiyu commented 6 months ago

As the title says

ti-chi-bot[bot] commented 6 months ago

@guo-shaoge: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to [this](https://github.com/pingcap/community/pull/779#pullrequestreview-1835773700): > Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.

guo-shaoge commented 6 months ago

zanmato1984 commented 6 months ago

ti-chi-bot[bot] commented 6 months ago

@SeaRise: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to [this](https://github.com/pingcap/community/pull/779#pullrequestreview-1835785735): > Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.

SeaRise commented 6 months ago

breezewish commented 6 months ago

Congrats!

zhangyangyu commented 5 months ago

/approve

wuhuizuo commented 5 months ago

/hold

wuhuizuo commented 5 months ago

@XuHuaiyu please update the team json file.

ti-chi-bot[bot] commented 5 months ago

[LGTM Timeline notifier]

Timeline:

2024-01-22 07:31:23.968539455 +0000 UTC m=+773125.532837160: :ballot_box_with_check: agreed by zimulala.
2024-01-29 05:38:44.092980239 +0000 UTC m=+1371165.657277944: :heavy_multiplication_x::repeat: reset by XuHuaiyu.

ti-chi-bot[bot] commented 5 months ago

New changes are detected. LGTM label has been removed.

zhangyangyu commented 5 months ago

/approve

ti-chi-bot[bot] commented 5 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bb7133, guo-shaoge, SeaRise, zhangyangyu, zimulala

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[teams/tidb/OWNERS](https://github.com/pingcap/community/blob/master/teams/tidb/OWNERS)~~ [bb7133,zimulala] - ~~[votes/OWNERS](https://github.com/pingcap/community/blob/master/votes/OWNERS)~~ [zhangyangyu] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment