pingcap / community

TiDB community content

Apache License 2.0

260 stars 151 forks source link

a vote for lidezhu as a committer #782

Closed asddongmen closed 4 months ago

asddongmen commented 4 months ago

A Vote for lidezhu as Migration Committer

Proposal

lidezhu have contributed a lot to TiFlow repo, he has fixed several issues and has been doing some enhancement work in TiCDC.

I (@asddongmen) hereby nominate @lidezhu as migration committer and call for a vote.

Deadline

The vote will be open for at least 6 days unless there is an objection or not enough votes.

Scope

Team Migration

Result

See also here.

zhangyangyu commented 4 months ago

/hold

wuhuizuo commented 4 months ago

missed vote markdown file

ti-chi-bot[bot] commented 4 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kennytm, zhangyangyu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[teams/migration/OWNERS](https://github.com/pingcap/community/blob/master/teams/migration/OWNERS)~~ [kennytm] - ~~[votes/OWNERS](https://github.com/pingcap/community/blob/master/votes/OWNERS)~~ [zhangyangyu] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment

ti-chi-bot[bot] commented 4 months ago

[LGTM Timeline notifier]

Timeline:

2024-03-18 07:53:32.380569353 +0000 UTC m=+1276839.402815738: :ballot_box_with_check: agreed by kennytm.
2024-03-20 03:35:51.177569257 +0000 UTC m=+1434178.199815645: :heavy_multiplication_x::repeat: reset by asddongmen.
2024-03-25 06:14:03.243353012 +0000 UTC m=+1875670.265599400: :ballot_box_with_check: agreed by zhangyangyu.

zhangyangyu commented 4 months ago

/merge

wuhuizuo commented 4 months ago

/unhold

let the bot auto merge it.