pingcap / community

TiDB community content
Apache License 2.0
263 stars 153 forks source link

teams/migration: A Vote for zhangjinpeng87 as Migration Committer #783

Closed CharlesCheung96 closed 7 months ago

CharlesCheung96 commented 7 months ago

A Vote for zhangjinpeng87 as Migration Committer

Proposal

@zhangjinpeng87 is the head of TiDB Data Platform team. He has focused on the system architecture and further iteration of data migration, and contributed greatly to improving the stability and observability of TiCDC.

Here lists the details of his contribution:

I (@CharlesCheung96) hereby nominate @zhangjinpeng87 as migration committer and call for a vote for the following reasons:

Deadline

The vote will be open for at least 6 days unless there is an objection or not enough votes.

Scope

Result

Approved by x binding votes

See also https://github.com/pingcap/community/pull/783.

sre-bot commented 7 months ago

CLA assistant check
All committers have signed the CLA.

ti-chi-bot[bot] commented 7 months ago

[LGTM Timeline notifier]

Timeline:

ti-chi-bot[bot] commented 7 months ago

@hi-rustin: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to [this](https://github.com/pingcap/community/pull/783#pullrequestreview-1984846412): > Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
ti-chi-bot[bot] commented 7 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hi-rustin, kennytm, lance6716, zhangyangyu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[teams/migration/OWNERS](https://github.com/pingcap/community/blob/master/teams/migration/OWNERS)~~ [kennytm,lance6716] - ~~[votes/OWNERS](https://github.com/pingcap/community/blob/master/votes/OWNERS)~~ [zhangyangyu] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment