search

pingcap / community

TiDB community content
Apache License 2.0
260 stars 151 forks source link

Vote: Nominate windtalker as TiFlash maintainer #787

Closed zanmato1984 closed 2 months ago

zanmato1984 commented 2 months ago

See the content of the included vote file.

ti-chi-bot[bot] commented 2 months ago

[LGTM Timeline notifier]

Timeline:

ti-chi-bot[bot] commented 2 months ago

@Lloyd-Pottiger: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to [this](https://github.com/pingcap/community/pull/787#pullrequestreview-2059823416): > Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
zanmato1984 commented 2 months ago

Maintainer @ilovesoup is currently having troubles of account so he asked me to cast a +1 vote on his behalf.

ti-chi-bot[bot] commented 2 months ago

@SeaRise: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to [this](https://github.com/pingcap/community/pull/787#pullrequestreview-2060412851): > Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
ti-chi-bot[bot] commented 2 months ago

@JaySon-Huang: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to [this](https://github.com/pingcap/community/pull/787#pullrequestreview-2060742614): >LGTM Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
zanmato1984 commented 2 months ago

Shall we move on with this? @zhangyangyu

ti-chi-bot[bot] commented 2 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: flowbehappy, JaySon-Huang, Lloyd-Pottiger, SeaRise, zhangyangyu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[teams/tiflash/OWNERS](https://github.com/pingcap/community/blob/master/teams/tiflash/OWNERS)~~ [flowbehappy] - ~~[votes/OWNERS](https://github.com/pingcap/community/blob/master/votes/OWNERS)~~ [zhangyangyu] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment