search

pingcap / community

TiDB community content
Apache License 2.0
263 stars 153 forks source link

teams/migration: A Vote for wk989898 as Migration Committer #790

Closed CharlesCheung96 closed 2 months ago

CharlesCheung96 commented 2 months ago

A Vote for wk989898 as Migration Committer

Proposal

@wk989898 have contributed a lot to TiFlow repo, he has fixed several issues and added several core features in TiCDC, including Kafka consumer enhancement and vector type support, etc.

Here lists the details of his contribution:

I (@CharlesCheung96) hereby nominate @wk989898 as migration committer and call for a vote for the following reasons:

Deadline

The vote will be open for at least 6 days unless there is an objection or not enough votes.

Scope

Result

Approved by x binding votes

See also https://github.com/pingcap/community/pull/790.

CharlesCheung96 commented 2 months ago

/hold for 6 days

/cc @3AceShowHand @flowbehappy

ti-chi-bot[bot] commented 2 months ago

@CharlesCheung96: GitHub didn't allow me to request PR reviews from the following users: 3AceShowHand.

Note that only pingcap members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to [this](https://github.com/pingcap/community/pull/790#issuecomment-2325570619): >/hold for 6 days > >/cc @3AceShowHand @flowbehappy Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
ti-chi-bot[bot] commented 2 months ago

[LGTM Timeline notifier]

Timeline:

ti-chi-bot[bot] commented 2 months ago

@3AceShowHand: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to [this](https://github.com/pingcap/community/pull/790#pullrequestreview-2276542362): > Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
ti-chi-bot[bot] commented 2 months ago

@hicqu: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to [this](https://github.com/pingcap/community/pull/790#pullrequestreview-2276566670): > Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
ti-chi-bot[bot] commented 2 months ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: 3AceShowHand, flowbehappy, hicqu, kennytm Once this PR has been reviewed and has the lgtm label, please assign zhangyangyu for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - ~~[teams/migration/OWNERS](https://github.com/pingcap/community/blob/master/teams/migration/OWNERS)~~ [kennytm] - **[votes/OWNERS](https://github.com/pingcap/community/blob/master/votes/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment