pingcap / diag

A tool to collect diagnostic data from TiDB Clusters
https://docs.pingcap.com/tidb/stable/clinic-introduction
Apache License 2.0
24 stars 9 forks source link

fix cannot show error message when fail to rebuild #444

Closed nexustar closed 1 year ago

nexustar commented 1 year ago

What problem does this PR solve?

What is changed and how it works?

Check List

Tests

Code changes

Side effects

Related changes

codecov-commenter commented 1 year ago

Codecov Report

Patch coverage: 9.09% and project coverage change: -0.05 :warning:

Comparison is base (c0cacb0) 30.11% compared to head (f8e35bf) 30.05%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #444 +/- ## ========================================== - Coverage 30.11% 30.05% -0.05% ========================================== Files 50 50 Lines 4218 4229 +11 ========================================== + Hits 1270 1271 +1 - Misses 2778 2788 +10 Partials 170 170 ``` | Flag | Coverage Δ | | |---|---|---| | unittests | `30.05% <9.09%> (-0.05%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pingcap#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://app.codecov.io/gh/pingcap/diag/pull/444?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pingcap) | Coverage Δ | | |---|---|---| | [pkg/packager/packager.go](https://app.codecov.io/gh/pingcap/diag/pull/444?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pingcap#diff-cGtnL3BhY2thZ2VyL3BhY2thZ2VyLmdv) | `13.88% <0.00%> (-0.20%)` | :arrow_down: | | [pkg/utils/utils.go](https://app.codecov.io/gh/pingcap/diag/pull/444?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pingcap#diff-cGtnL3V0aWxzL3V0aWxzLmdv) | `0.00% <0.00%> (ø)` | | | [cmd/diag/command/util\_metricdump.go](https://app.codecov.io/gh/pingcap/diag/pull/444?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pingcap#diff-Y21kL2RpYWcvY29tbWFuZC91dGlsX21ldHJpY2R1bXAuZ28=) | `37.14% <100.00%> (+0.60%)` | :arrow_up: |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.