Closed zyguan closed 5 months ago
All modified and coverable lines are covered by tests :white_check_mark:
Comparison is base (
4c0b393
) 30.21% compared to head (913f819
) 30.21%.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
What problem does this PR solve?
For a large cluster,
getSeriesNum
may always fail due to quota limit. As a result, significant metrics liketidb_tikvclient_request_seconds
andtikv_grpc_msg_duration_seconds
are often missing, which blocks troubleshooting.What is changed and how it works?
With this PR, if
getSeriesNum
failed, diag will fallback to by-instance dump mode, which get instance list first and callcollectMetric
by instance.Check List
Tests
Code changes
Side effects
Related changes