search

pingcap / dm

Data Migration Platform
Apache License 2.0
456 stars 188 forks source link

onlineddl: report an error when online ddl only matches only one regex (#2182) #2184

Closed ti-chi-bot closed 3 years ago

ti-chi-bot commented 3 years ago

This is an automated cherry-pick of #2182

What problem does this PR solve?

When we mistakenly configure trash-table-rules in online ddl, downstream real table might be renamed to fake trash table.

What is changed and how it works?

Give a warning to users when they mistakenly configure only trash-table-rules or shadow-table-rules and don't execute any ddl to downstream at this time.

Check List

Tests

Side effects

Related changes

ti-chi-bot commented 3 years ago

[REVIEW NOTIFICATION]

This pull request has been approved by:

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment. After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review. Reviewer can cancel approval by submitting a request changes review.
lichunzhu commented 3 years ago

/verify

lichunzhu commented 3 years ago

/merge

ti-chi-bot commented 3 years ago

This pull request has been accepted and is ready to merge.

Commit hash: 371e922b89280ce1e37e3b0151ba8010ad94b644

lichunzhu commented 3 years ago

/cherry-pick release-2.0.7

ti-chi-bot commented 3 years ago

@lichunzhu: new pull request created: #2185.

In response to [this](https://github.com/pingcap/dm/pull/2184#issuecomment-929348216): >/cherry-pick release-2.0.7 Instructions for interacting with me using PR comments are available [here](https://prow.tidb.io/command-help). If you have questions or suggestions related to my behavior, please file an issue against the [ti-community-infra/tichi](https://github.com/ti-community-infra/tichi/issues/new?title=Prow%20issue:) repository.