pingcap / dm

Data Migration Platform
Apache License 2.0
456 stars 188 forks source link

scheduler: little refinement #2211

Closed lance6716 closed 3 years ago

lance6716 commented 3 years ago

What problem does this PR solve?

reduce code repeat. In future PRs we will check about relay worker bugs.

What is changed and how it works?

little refinement

Check List

Tests

Side effects

Related changes

ti-chi-bot commented 3 years ago

[REVIEW NOTIFICATION]

This pull request has been approved by:

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment. After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review. Reviewer can cancel approval by submitting a request changes review.
lance6716 commented 3 years ago

/cc @GMHDBJD @lichunzhu a short PR

ti-chi-bot commented 3 years ago

@lance6716: GitHub didn't allow me to request PR reviews from the following users: a, short, PR.

Note that only pingcap members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to [this](https://github.com/pingcap/dm/pull/2211#issuecomment-940924773): >/cc @GMHDBJD @lichunzhu a short PR Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
lance6716 commented 3 years ago

/cc @GMHDBJD @lichunzhu

a short PR

lance6716 commented 3 years ago

/merge

ti-chi-bot commented 3 years ago

This pull request has been accepted and is ready to merge.

Commit hash: e38ea8a4b38b3c3dd63372fba8671421193c26ac

ti-chi-bot commented 3 years ago

In response to a cherrypick label: new pull request created: #2212.