search

pingcap / dm

Data Migration Platform
Apache License 2.0
456 stars 188 forks source link

relay: add pullBinlogs interface for dm-worker to get local/grpc relay log #2216

Closed lichunzhu closed 3 years ago

lichunzhu commented 3 years ago

What problem does this PR solve?

Close https://github.com/pingcap/dm/issues/2214

What is changed and how it works?

  1. Add PullBinlogs interface for server side.
  2. Add PullBinlogs for client side for local way.

Check List

Tests

Code changes

Related changes

ti-chi-bot commented 3 years ago

[REVIEW NOTIFICATION]

This pull request has been approved by:

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment. After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review. Reviewer can cancel approval by submitting a request changes review.
lichunzhu commented 3 years ago

/cc @D3Hunter

ti-chi-bot commented 3 years ago

@lichunzhu: GitHub didn't allow me to request PR reviews from the following users: D3Hunter.

Note that only pingcap members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to [this](https://github.com/pingcap/dm/pull/2216#issuecomment-941957743): >/cc @D3Hunter Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
lichunzhu commented 3 years ago

ping @lance6716 @Ehco1996 @D3Hunter

ti-chi-bot commented 3 years ago

@lichunzhu: PR needs rebase.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
lichunzhu commented 3 years ago

merge this in next sprint

lance6716 commented 3 years ago

BTW, the perfect interface in my mind is using MySQL replication protocal, so someday we can decouple "relay log" functionalities from DM worker, DM worker will transparently connect to relay log nodes or real upstream.

cc @sunzhaoyang