support explicitly set time_zone and change default time_zone to target db tz

pingcap / dm

Data Migration Platform

Apache License 2.0

456 stars 188 forks source link

support explicitly set time_zone and change default time_zone to target db tz #2217

Closed glorv closed 3 years ago

glorv commented 3 years ago

What problem does this PR solve?

What is changed and how it works?

Change the default time_zone setting from UTC to the global time_zone setting from target db.
Add back the time_zone in TaskConfig because this is useful in some special cases.

Check List

Tests

Unit test
Integration test

Code changes

Side effects

Related changes

Need to be included in the release note

ti-chi-bot commented 3 years ago

[REVIEW NOTIFICATION]

This pull request has been approved by:

lance6716

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment. After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review. Reviewer can cancel approval by submitting a request changes review.