search

pingcap / dm

Data Migration Platform
Apache License 2.0
456 stars 188 forks source link

test: remove send lark notify #2245

Closed Ehco1996 closed 3 years ago

Ehco1996 commented 3 years ago

What problem does this PR solve?

Since we have email notifications from github and slack, there is no need to have another lark's notifications

What is changed and how it works?

Check List

Tests

Code changes

Side effects

Related changes

ti-chi-bot commented 3 years ago

[REVIEW NOTIFICATION]

This pull request has been approved by:

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment. After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review. Reviewer can cancel approval by submitting a request changes review.
D3Hunter commented 3 years ago

What problem does this PR solve? as title

this answers nothing, maybe we can add more context info in the description

ti-chi-bot commented 3 years ago

@D3Hunter: Thanks for your review. The bot only counts approvals from reviewers and higher roles in list, but you're still welcome to leave your comments.

In response to [this](https://github.com/pingcap/dm/pull/2245#pullrequestreview-785182299): > Instructions for interacting with me using PR comments are available [here](https://prow.tidb.io/command-help). If you have questions or suggestions related to my behavior, please file an issue against the [ti-community-infra/tichi](https://github.com/ti-community-infra/tichi/issues/new?title=Prow%20issue:) repository.
Ehco1996 commented 3 years ago

/run-integration-test /run-unit-tests

lance6716 commented 3 years ago

/remove-status LGT1 /status LGT2

lance6716 commented 3 years ago

/merge

ti-chi-bot commented 3 years ago

This pull request has been accepted and is ready to merge.

Commit hash: 898528675d49744cb1b421ea8e41eddfaa6f7b9e

ti-chi-bot commented 3 years ago

In response to a cherrypick label: new pull request created: #2248.