Closed Oreoxmt closed 1 year ago
/approve
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: Oreoxmt
The full list of commands accepted by this bot can be found here.
The pull request process is described here
In response to a cherrypick label: new pull request created to branch release-1.3
: #2418.
In response to a cherrypick label: new pull request created to branch release-1.4
: #2419.
In response to a cherrypick label: new pull request created to branch release-1.5
: #2420.
In response to a cherrypick label: new pull request created to branch release-1.2
: #2421.
First-time contributors' checklist
What is changed, added, or deleted? (Required)
Fix an issue that the
prevent-deletion.yaml
workflow mistakenly detects image deletions when images are added or removed in the PR's base branch. The root cause of this issue is that the workflow directly compares the latest commit of the PR base branch with the latest commit of the PR.This PR improves the accuracy of the image deletion detection script by adding the
--merge-base
option to thegit diff
command. This change ensures that git calculates the changes from the shared starting point of the HEAD and the PR head SHA.Which TiDB Operator version(s) do your changes apply to? (Required)
What is the related PR or file link(s)?