ci: update the git diff command in the prevent deletion workflow to improve accuracy (#2417)

ti-chi-bot commented 1 year ago

This is an automated cherry-pick of #2417

First-time contributors' checklist

[ ] I've signed Contributor License Agreement that's required for repo owners to accept my contribution.

What is changed, added, or deleted? (Required)

Fix an issue that the prevent-deletion.yaml workflow mistakenly detects image deletions when images are added or removed in the PR's base branch. The root cause of this issue is that the workflow directly compares the latest commit of the PR base branch with the latest commit of the PR.

This PR improves the accuracy of the image deletion detection script by adding the --merge-base option to the git diff command. This change ensures that git calculates the changes from the shared starting point of the HEAD and the PR head SHA.

Which TiDB Operator version(s) do your changes apply to? (Required)

[x] master (the latest development version)
[x] v1.5 (TiDB Operator 1.5 versions)
[x] v1.4 (TiDB Operator 1.4 versions)
[x] v1.3 (TiDB Operator 1.3 versions)
[x] v1.2 (TiDB Operator 1.2 versions)

What is the related PR or file link(s)?

This PR is translated from:
Other reference link(s):

Oreoxmt commented 1 year ago

/approve

ti-chi-bot[bot] commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Oreoxmt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/pingcap/docs-tidb-operator/blob/release-1.4/OWNERS)~~ [Oreoxmt] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment

pingcap / docs-tidb-operator