pingcap / docs-tidb-operator

Documentation for TiDB on Kubernetes in both English and Chinese.
https://docs.pingcap.com/tidb-in-kubernetes
Other
46 stars 118 forks source link

tiproxy: add description on graceful-wait and signing-cert #2503

Closed xhebox closed 5 months ago

xhebox commented 5 months ago

First-time contributors' checklist

What is changed, added, or deleted? (Required)

Which TiDB Operator version(s) do your changes apply to? (Required)

What is the related PR or file link(s)?

ti-chi-bot[bot] commented 5 months ago

@djshow832: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to [this](https://github.com/pingcap/docs-tidb-operator/pull/2503#pullrequestreview-1840935428): > Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
ti-chi-bot[bot] commented 5 months ago

[LGTM Timeline notifier]

Timeline:

ran-huang commented 5 months ago

/approve

ti-chi-bot[bot] commented 5 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ran-huang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/pingcap/docs-tidb-operator/blob/master/OWNERS)~~ [ran-huang] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
ti-chi-bot commented 5 months ago

In response to a cherrypick label: new pull request created to branch release-1.5: #2504.