search

pingcap / docs-tidb-operator

Documentation for TiDB on Kubernetes. TiDB is an open-source, cloud-native, distributed, MySQL-Compatible database for elastic scale and real-time analytics. Try AI-powered Chat2Query free at : https://www.pingcap.com/tidb-serverless/
https://docs.pingcap.com/tidb-in-kubernetes
Other
47 stars 120 forks source link

Add doc for ad-hoc mod for Lightning #862

Closed DanielZhangQD closed 3 years ago

DanielZhangQD commented 3 years ago

Change Request

This repository is ONLY used to solve issues related to TiDB Operator documentation. For other issues (related to TiDB, PD, etc), please move to other repositories.

Please answer the following questions before submitting your issue. Thanks!

  1. Describe what you find is inappropriate or missing in the existing docs.

The data import with tidb-lightning chart supports the following three modes:

However, the ad-hoc mod is not covered in the current doc https://docs.pingcap.com/zh/tidb-in-kubernetes/stable/restore-data-using-tidb-lightning, which needs to update.

  1. Describe your suggestion or addition.

  2. Provide some reference materials (documents, websites, etc) if you could.

DanielZhangQD commented 3 years ago

/assign @BinChenn

DanielZhangQD commented 3 years ago

/unassign @BinChenn

DanielZhangQD commented 3 years ago

/assign @csuzhangxc

csuzhangxc commented 3 years ago

@DanielZhangQD we remove backup data after archived (https://github.com/pingcap/tidb-operator/blob/6b44131af7eb94acb8cdaadf1e8847ba01200922/cmd/backup-manager/app/export/manager.go#L322) and remove archived data after uploaded to remote (https://github.com/pingcap/tidb-operator/blob/6b44131af7eb94acb8cdaadf1e8847ba01200922/cmd/backup-manager/app/export/manager.go#L350).

so, I think ad-hoc should not work now. Should we need to:

DanielZhangQD commented 3 years ago

@csuzhangxc It's still useful with the current behavior. We have a user that has 16 TB backup, and it may take 48 hours to download the files from S3, and then the import with tidb-lightning failed, in this case, we can reuse the PVC, and no need to download the files again.

add an option to keep the backup data locally for ad-hoc

For this, we can support it if some users request this later, WDYT?

csuzhangxc commented 3 years ago

OK. I'll update docs for the case you mentioned above.

For this, we can support it if some users request this later, WDYT?

SGTM