Open qiancai opened 1 week ago
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please ask for approval from qiancai, ensuring that each of them provides their approval before proceeding. For more information see the Code Review Process.
The full list of commands accepted by this bot can be found here.
@mjonss I assume that partitioning and global index work as expected when it comes to the storage size explained here?
TIKV_REGION_STATUS
seems to depend on Prometheus being available. However this isn't noted on https://docs.pingcap.com/tidb/stable/information-schema-tikv-region-status
The result is that size calculation would fail with this error:
ERROR 1105 (HY000): query metric error: [domain:9009]Prometheus address is not set in PD and etcd
If a custom Prometheus is used then the address might not be configured correctly in pd/etcd. If there is no Prometheus we may want to see if there are any alternatives available
@AilinKid: adding LGTM is restricted to approvers and reviewers in OWNERS files.
First-time contributors' checklist
What is changed, added or deleted? (Required)
Add a note for DATA_LENGTH, INDEX_LENGTH, and TABLE_SIZE to explain they are logical estimates instead of actual physical sizes.
Which TiDB version(s) do your changes apply to? (Required)
Tips for choosing the affected version(s):
By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.
For details, see tips for choosing the affected versions.
What is the related PR or file link(s)?
Do your changes match any of the following descriptions?