search

pingcap / dumpling

Dumpling is a fast, easy-to-use tool written by Go for dumping data from the database(MySQL, TiDB...) to local/cloud(S3, GCP...) in multifarious formats(SQL, CSV...).
Apache License 2.0
281 stars 85 forks source link

*: replace storage.Create by storage.New, upgrade dumpling CI to go 1.16 #286

Closed lichunzhu closed 3 years ago

lichunzhu commented 3 years ago

What problem does this PR solve?

https://github.com/pingcap/br/issues/898

  1. storage.Create has been deprecated... so let's replace the remaining two calls from Dumpling.
  2. Dumpling originally used storage.Create(sendCreds=true), but the entire cloud access happens within Lightning, so we don't need to send credentials to anyone this introduced skipCheckPath=false.

What is changed and how it works?

  1. Changed storage.Create to storage.New with sendCreds=false and skipCheckPath=true.
  2. Upgrade dumpling go version to 1.16.

Check List

Tests

Side effects

Related changes

Release note

glorv commented 3 years ago

/lgtm

ti-chi-bot commented 3 years ago

[REVIEW NOTIFICATION]

This pull request has been approved by:

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment. After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by writing `/lgtm` in a comment. Reviewer can cancel approval by writing `/lgtm cancel` in a comment.
lichunzhu commented 3 years ago

/merge

ti-chi-bot commented 3 years ago

This pull request has been accepted and is ready to merge.

Commit hash: 71654784b857cc2584ddf37ca0c35333069d59bd

lichunzhu commented 3 years ago

/hold

lichunzhu commented 3 years ago

/unhold

lichunzhu commented 3 years ago

/merge

ti-chi-bot commented 3 years ago

This pull request has been accepted and is ready to merge.

Commit hash: b5c6bc49c6c93609cb76961179ffb1a995d27423

ti-chi-bot commented 3 years ago

In response to a cherrypick label: new pull request created: #287.

ti-chi-bot commented 3 years ago

In response to a cherrypick label: new pull request created: #288.