pingcap / dumpling

Dumpling is a fast, easy-to-use tool written by Go for dumping data from the database(MySQL, TiDB...) to local/cloud(S3, GCP...) in multifarious formats(SQL, CSV...).
Apache License 2.0
280 stars 85 forks source link

security: support init tls config from cert/key/ca bytes #319

Closed Ehco1996 closed 3 years ago

Ehco1996 commented 3 years ago

What problem does this PR solve?

as title

What is changed and how it works?

Check List

Tests

Side effects

Related changes

Release note

ti-chi-bot commented 3 years ago

[REVIEW NOTIFICATION]

This pull request has been approved by:

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment. After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review. Reviewer can cancel approval by submitting a request changes review.
CLAassistant commented 3 years ago

CLA assistant check
All committers have signed the CLA.

Ehco1996 commented 3 years ago

@lichunzhu ci make check timeout, but I don't have restart access, is there any command to do that?

lichunzhu commented 3 years ago

/merge

ti-chi-bot commented 3 years ago

This pull request has been accepted and is ready to merge.

Commit hash: fc596ae5eee8f777f1cfccd696c38df2f7afc27b