*: use different connetion in consistencyTypeFlush

pingcap / dumpling

Dumpling is a fast, easy-to-use tool written by Go for dumping data from the database(MySQL, TiDB...) to local/cloud(S3, GCP...) in multifarious formats(SQL, CSV...).

Apache License 2.0

280 stars 85 forks source link

*: use different connetion in consistencyTypeFlush #323

Closed Ehco1996 closed 3 years ago

Ehco1996 commented 3 years ago

What problem does this PR solve?

https://github.com/pingcap/dumpling/issues/322

What is changed and how it works?

use different mysql connetion between FLUSH TABLES WITH READ LOCK and unlock tables

Check List

Tests

Unit test
Integration test

Side effects

Possible performance regression
Increased code complexity

Related changes

Need to cherry-pick to the release branch
Need to update the documentation

Release note

fix pending on dump when use mysql 8.0.19

ti-chi-bot commented 3 years ago

[REVIEW NOTIFICATION]

This pull request has not been approved.

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment. After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review. Reviewer can cancel approval by submitting a request changes review.

Ehco1996 commented 3 years ago

If two connections are used to lock mysql's read lock will fail because mysql will implicitly execute unlock tables when the connection is closed for the statement FLush TABLES WITH READ LOCK.