search

pingcap / dumpling

Dumpling is a fast, easy-to-use tool written by Go for dumping data from the database(MySQL, TiDB...) to local/cloud(S3, GCP...) in multifarious formats(SQL, CSV...).
Apache License 2.0
280 stars 85 forks source link

prepare: filter databases before show table status #324

Closed lichunzhu closed 3 years ago

lichunzhu commented 3 years ago

What problem does this PR solve?

In https://github.com/pingcap/dumpling/pull/305, we have switched the method to get table info to SHOW TABLE STATUS. To reduce the access to databases, we'd better filter databases before we executing SHOW TABLE STATUS.

What is changed and how it works?

Filter databases before SHOW TABLE STATUS through conf.Filter.

Check List

Tests

Related changes

Release note

ti-chi-bot commented 3 years ago

[REVIEW NOTIFICATION]

This pull request has been approved by:

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment. After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review. Reviewer can cancel approval by submitting a request changes review.
lichunzhu commented 3 years ago

/merge

ti-chi-bot commented 3 years ago

This pull request has been accepted and is ready to merge.

Commit hash: f375384434a744d740af7a88af0001942256cd9e

ti-chi-bot commented 3 years ago

In response to a cherrypick label: new pull request created: #336.

ti-chi-bot commented 3 years ago

In response to a cherrypick label: new pull request created: #337.

ti-chi-bot commented 3 years ago

In response to a cherrypick label: new pull request created: #338.

ti-chi-bot commented 2 years ago

In response to a cherrypick label: new pull request created: #367.