*: use `show full tables` in ListAllDatabasesTables

pingcap / dumpling

Dumpling is a fast, easy-to-use tool written by Go for dumping data from the database(MySQL, TiDB...) to local/cloud(S3, GCP...) in multifarious formats(SQL, CSV...).

Apache License 2.0

280 stars 85 forks source link

*: use `show full tables` in ListAllDatabasesTables #325

Closed Ehco1996 closed 3 years ago

Ehco1996 commented 3 years ago

What problem does this PR solve?

close #322

What is changed and how it works?

when meet a specific buggy version of mysql [8.0.3 8.0.23), use SQL show full tables to get all table names from upstream database.

As the average data size per row of data is not taken from the Show full table results, dumpling will set this value to 200000. This has the potential to cause the user to export too many or too few files, but I find this more acceptable than getting stuck in the dump stage.

Check List

Tests

Unit test
Integration test

Side effects

Possible performance regression
Increased code complexity

Related changes

Need to cherry-pick to the release branch
Need to update the documentation

Release note

fix pending on show table status in some mysql version

ti-chi-bot commented 3 years ago

[REVIEW NOTIFICATION]

This pull request has been approved by:

lichunzhu

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment. After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review. Reviewer can cancel approval by submitting a request changes review.

Ehco1996 commented 3 years ago

@lichunzhu all comments are resloved PTAL

lichunzhu commented 3 years ago

/merge cancel

lichunzhu commented 3 years ago

/merge

lichunzhu commented 3 years ago

/merge cancel

lichunzhu commented 3 years ago

/merge

ti-chi-bot commented 3 years ago

This pull request has been accepted and is ready to merge.

Commit hash: f159d85988155a3130bf69a79e7d8c8ea64a9ad3

ti-chi-bot commented 3 years ago

In response to a cherrypick label: new pull request created: #331.

ti-chi-bot commented 3 years ago

In response to a cherrypick label: new pull request created: #332.

ti-chi-bot commented 3 years ago

In response to a cherrypick label: new pull request created: #333.

ti-chi-bot commented 3 years ago

In response to a cherrypick label: new pull request created: #342.