support --max-idle-time argument

pingcap / dumpling

Dumpling is a fast, easy-to-use tool written by Go for dumping data from the database(MySQL, TiDB...) to local/cloud(S3, GCP...) in multifarious formats(SQL, CSV...).

Apache License 2.0

280 stars 85 forks source link

support --max-idle-time argument #326

Open dbakit opened 3 years ago

dbakit commented 3 years ago

See https://github.com/pingcap/dumpling/issues/282

ti-chi-bot commented 3 years ago

[REVIEW NOTIFICATION]

This pull request has not been approved.

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment. After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review. Reviewer can cancel approval by submitting a request changes review.

CLAassistant commented 3 years ago

All committers have signed the CLA.

ti-chi-bot commented 3 years ago

Welcome @dba-kit!

It looks like this is your first PR to pingcap/dumpling 🎉.

I'm the bot to help you request reviewers, add labels and more, See available commands.

We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to pingcap/dumpling. :smiley:

lichunzhu commented 3 years ago

@dba-kit Could you please help sign the CLA?

lance6716 commented 3 years ago

this commit https://github.com/pingcap/dumpling/pull/326/commits/de1f43ddf95c5d1ce15b0246e5d20a9716cdd331 is associated with another email rather than your GitHub account. You can change commit email address and fix this problem (maybe file another PR).

dbakit commented 3 years ago

@dba-kit Could you please help sign the CLA?

done, but I find I delete a line in v4/export/config.go by mistake

_ = flags.MarkHidden(flagReadTimeout)

lichunzhu commented 2 years ago

@dba-kit hello, Dumpling has been moved to https://github.com/pingcap/tidb/tree/master/dumpling now. Could you please help move this PR to pingcap/tidb?