search

pingcap / dumpling

Dumpling is a fast, easy-to-use tool written by Go for dumping data from the database(MySQL, TiDB...) to local/cloud(S3, GCP...) in multifarious formats(SQL, CSV...).
Apache License 2.0
280 stars 85 forks source link

*: update dumpling log and pd usage #335

Closed lichunzhu closed 3 years ago

lichunzhu commented 3 years ago

What problem does this PR solve?

  1. Dumpling's warning log with error stack may terrify users. Users may think the dump task is failed but actually, it's not.
  2. Dumpling may fail when dumpling account lacks privileges for MYSQL.TiDB.

What is changed and how it works?

  1. Change error stack to short error.
  2. Ignore all errors when trying auto adjust gc to PD.

Check List

Tests

Related changes

Release note

ti-chi-bot commented 3 years ago

[REVIEW NOTIFICATION]

This pull request has been approved by:

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment. After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review. Reviewer can cancel approval by submitting a request changes review.
lichunzhu commented 3 years ago

/merge

ti-chi-bot commented 3 years ago

This pull request has been accepted and is ready to merge.

Commit hash: 22b1f8cc31af5f9fb92fef17357a059662bb14c4

ti-chi-bot commented 3 years ago

In response to a cherrypick label: new pull request created: #339.

ti-chi-bot commented 3 years ago

In response to a cherrypick label: new pull request created: #340.

ti-chi-bot commented 3 years ago

In response to a cherrypick label: new pull request created: #341.

ti-chi-bot commented 2 years ago

In response to a cherrypick label: new pull request created: #368.