Closed tisonkun closed 3 years ago
[REVIEW NOTIFICATION]
This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer
in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer
in the comment to help you merge this pull request.
The full list of commands accepted by this bot can be found here.
/cc @kennytm
would you like to give another look?
@lichunzhu updated. PTAL
The group imports in other files are also not in the same style. But it seems not a big problem? Or do we have lint tools to do this job easily?
@lichunzhu I think they are in the same style "goimports" while goimports doesn't have a strict rule to group imports as much as possible.
BTW, pingcap/tidb also use goimports
/merge
This pull request has been accepted and is ready to merge.
In response to a cherrypick label: new pull request created: #347.
In response to a cherrypick label: new pull request created: #348.
In response to a cherrypick label: new pull request created: #349.
In response to a cherrypick label: cannot checkout 5.2
: error checking out 5.2: exit status 1. output: error: pathspec '5.2' did not match any file(s) known to git
/cherry-pick release-5.2
@lichunzhu: new pull request created: #364.
What problem does this PR solve?
pingcap/check is no longer under maintenance, migrate to testify.
This PR can be somewhat regarded as a subtask of https://github.com/pingcap/tidb/issues/26022
This closes #346 .
Release note