search

pingcap / dumpling

Dumpling is a fast, easy-to-use tool written by Go for dumping data from the database(MySQL, TiDB...) to local/cloud(S3, GCP...) in multifarious formats(SQL, CSV...).
Apache License 2.0
280 stars 85 forks source link

*: migrate test-infra to testify #344

Closed tisonkun closed 3 years ago

tisonkun commented 3 years ago

What problem does this PR solve?

pingcap/check is no longer under maintenance, migrate to testify.

This PR can be somewhat regarded as a subtask of https://github.com/pingcap/tidb/issues/26022

This closes #346 .

Release note

ti-chi-bot commented 3 years ago

[REVIEW NOTIFICATION]

This pull request has been approved by:

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment. After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review. Reviewer can cancel approval by submitting a request changes review.
tisonkun commented 3 years ago

/cc @kennytm

would you like to give another look?

tisonkun commented 3 years ago

@lichunzhu updated. PTAL

lichunzhu commented 3 years ago

The group imports in other files are also not in the same style. But it seems not a big problem? Or do we have lint tools to do this job easily?

tisonkun commented 3 years ago

@lichunzhu I think they are in the same style "goimports" while goimports doesn't have a strict rule to group imports as much as possible.

tisonkun commented 3 years ago

BTW, pingcap/tidb also use goimports

lichunzhu commented 3 years ago

/merge

ti-chi-bot commented 3 years ago

This pull request has been accepted and is ready to merge.

Commit hash: 8943240589794de41e76bf101a8282065f4280a1

ti-chi-bot commented 3 years ago

In response to a cherrypick label: new pull request created: #347.

ti-chi-bot commented 3 years ago

In response to a cherrypick label: new pull request created: #348.

ti-chi-bot commented 3 years ago

In response to a cherrypick label: new pull request created: #349.

ti-chi-bot commented 3 years ago

In response to a cherrypick label: cannot checkout 5.2: error checking out 5.2: exit status 1. output: error: pathspec '5.2' did not match any file(s) known to git

lichunzhu commented 2 years ago

/cherry-pick release-5.2

ti-chi-bot commented 2 years ago

@lichunzhu: new pull request created: #364.

In response to [this](https://github.com/pingcap/dumpling/pull/344#issuecomment-940619373): >/cherry-pick release-5.2 Instructions for interacting with me using PR comments are available [here](https://prow.tidb.io/command-help). If you have questions or suggestions related to my behavior, please file an issue against the [ti-community-infra/tichi](https://github.com/ti-community-infra/tichi/issues/new?title=Prow%20issue:) repository.