search

pingcap / dumpling

Dumpling is a fast, easy-to-use tool written by Go for dumping data from the database(MySQL, TiDB...) to local/cloud(S3, GCP...) in multifarious formats(SQL, CSV...).
Apache License 2.0
281 stars 85 forks source link

export: close previous dbHandle before reset #356

Closed lance6716 closed 3 years ago

lance6716 commented 3 years ago

What problem does this PR solve?

https://github.com/pingcap/dm/issues/2127

What is changed and how it works?

as title

Check List

Tests

Side effects

Related changes

Release note

ti-chi-bot commented 3 years ago

[REVIEW NOTIFICATION]

This pull request has been approved by:

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment. After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review. Reviewer can cancel approval by submitting a request changes review.
lichunzhu commented 3 years ago

Sorry, it's a newly introduced bug. I think we can put Close function inside https://github.com/pingcap/dumpling/blob/master/v4/export/sql.go#L634 Besides, we'd better check where d.dbHandle is nil before https://github.com/pingcap/dumpling/blob/master/v4/export/dump.go#L969

lance6716 commented 3 years ago

/merge

ti-chi-bot commented 3 years ago

This pull request has been accepted and is ready to merge.

Commit hash: ebad8599304b8dd329373b95b979c79b745353d0