search

pingcap / dumpling

Dumpling is a fast, easy-to-use tool written by Go for dumping data from the database(MySQL, TiDB...) to local/cloud(S3, GCP...) in multifarious formats(SQL, CSV...).
Apache License 2.0
281 stars 85 forks source link

sql: fix where condition without brackets problem #372

Closed lichunzhu closed 3 years ago

lichunzhu commented 3 years ago

What problem does this PR solve?

close https://github.com/pingcap/dumpling/issues/371

What is changed and how it works?

If both conf.Where and where has a value, we use brackets to wrap these two conditions.

Check List

Tests

Side effects

Related changes

Release note

ti-chi-bot commented 3 years ago

[REVIEW NOTIFICATION]

This pull request has been approved by:

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment. After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review. Reviewer can cancel approval by submitting a request changes review.
lichunzhu commented 3 years ago

/merge

ti-chi-bot commented 3 years ago

This pull request has been accepted and is ready to merge.

Commit hash: e6d5341b52906f6943b8efee296f2874b5580a07

ti-chi-bot commented 3 years ago

In response to a cherrypick label: new pull request created: #373.

ti-chi-bot commented 3 years ago

In response to a cherrypick label: new pull request created: #374.

ti-chi-bot commented 3 years ago

In response to a cherrypick label: new pull request created: #375.

ti-chi-bot commented 3 years ago

In response to a cherrypick label: new pull request created: #376.