sql: fix where condition without brackets problem (#372)

pingcap / dumpling

Dumpling is a fast, easy-to-use tool written by Go for dumping data from the database(MySQL, TiDB...) to local/cloud(S3, GCP...) in multifarious formats(SQL, CSV...).

Apache License 2.0

279 stars 85 forks source link

sql: fix where condition without brackets problem (#372) #373

Closed ti-chi-bot closed 2 years ago

ti-chi-bot commented 2 years ago

This is an automated cherry-pick of #372

What problem does this PR solve?

close https://github.com/pingcap/dumpling/issues/371

What is changed and how it works?

If both conf.Where and where has a value, we use brackets to wrap these two conditions.

Check List

Tests

Unit test
Integration test Dumpling before this commit can't pass new integration tests.

Side effects

Possible performance regression

Related changes

Need to cherry-pick to the release branch

Release note

fix the problem that dumpling may dump extra data if --where is specified

ti-chi-bot commented 2 years ago

[REVIEW NOTIFICATION]

This pull request has been approved by:

glorv

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment. After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review. Reviewer can cancel approval by submitting a request changes review.

lichunzhu commented 2 years ago

/merge

ti-chi-bot commented 2 years ago

This pull request has been accepted and is ready to merge.

Commit hash: 5ee0f7a79055679ef04ab623f2d582e1061f5430